Mike Hodnick

PingBack from http://www.powershellhq.com/2006/11/30/zip-up-a-folder-and-email-it/

Mike,

Are you sure your zip-email script works?  I have added it to my profile as follows (where <???> represents my company server, hidden here for privacy/security reasons):

function test-it {
$sender = rwhiting@<mycompanyserver>.com
$recipient = rwhiting@<mycompanyserver>.com
$server = exchange2.<mycompanyserver>.com
$targetFolder = c:\MyFolder
$file = c:\MyZipFile.zip

if ( [System.IO.File]::Exists($file) ) {
 remove-item -force $file
}

gi $targetFolder | out-zip $file $_
$subject = "Sending a File " + [System.DateTime]::Now
$body = "I'm sending a file!"
$msg = new-object System.Net.Mail.MailMessage $sender, $recipient, $subject, $body
$attachment = new-object System.Net.Mail.Attachment $file
$msg.Attachments.Add($attachment)
$client = new-object System.Net.Mail.SmtpClient $server
$client.Credentials = [System.Net.CredentialCache]::DefaultNetworkCredentials
$client.Send($msg)
}

function out-zip {
$path = $args[0]
$files = $input

if (-not $path.EndsWith('.zip')) {$path += '.zip'}

if (-not (test-path $path)) {
 set-content $path ("PK" + [char]5 + [char]6 + ("$([char]0)" * 18))
}

$zipfile = (new-object -com shell.application).NameSpace($path)
$files | foreach {$zipfile.CopyHere($_.fullname) }
}

When I execute "test-it" within PowerShell 1.0, I get a series of error messages:


"The term 'rwhiting@<myserver>.com' is not recognized as a cmdlet, function, operable program, or script file. Verify the term and try again."

I get a similar message for "exchange2.<myserver>.com", "rwhiting@<myserver>.com", "MyFolder", and "c:\MyZipFile.zip".

And also (among others): "New-Object: Constructor not found. Cannot find an appropriate constructor for type System.Net.Mail.Attachment."

Am I doing something wrong, even though I basically cut-and-pasted the script?

Update on above question ...

When I add quotes around each of the literal string values:

    $sender =" rwhiting@<mycompanyserver>.com"
    $recipient =" rwhiting@<mycompanyserver>.com"
    $server =" exchange2.<mycompanyserver>.com"
    $targetFolder = "c:\MyFolder"
    $file =" c:\MyZipFile.zip"

I get fewer error messages, but still this one:

    New-Object: Exception calling ".ctor" with "1" argument(s): "Could not find file 'c:\MyZipFile.zip'."

even though the file DOES exist. Why can't PowerShell see it?

Further update ...

I had to change this line:

    $client.Credentials = new-object system.net.networkcredential("rwhiting","<mypassword>")

Now the script works fine when I enter it INTERACTIVELY, LINE-BY-LINE in PowerShell. But when I execute it AS A FUNCTION, it still does NOT work, but returns the same old error:

    New-Object: Exception calling ".ctor" with "1" argument(s): "Could not find file 'c:\MyZipFile.zip'."

Why does this script work when entered line-by-line interactively in PowerShell, but NOT when run as a function? What am I missing?

Thanks,

Solution ...

Okay, I figured it out. The line correction is:

    [System.Net.Mail.Attachment] $attachment = new-object System.Net.Mail.Attachment $file

It is necessary to cast the $attachment variable to type System.Net.Mail.Attachment, since new-object (in this instance) returns a REFERENCE to an object of that type, not an ACTUAL OBJECT of the type. But $msg.Attachments.Add($attachment) requires an actual object. Hence the need for the cast.

PingBack from http://www.pwrshell.com/2008/03/04/powershell-script-zip-up-a-folder-and-email-it/

PingBack from http://www.pwrshell.com/2008/03/04/powershell-script-zip-up-a-folder-and-email-it-2/